From cd0ac2bf437cc45b3d20a0b0c68308a2afceee59 Mon Sep 17 00:00:00 2001
From: Ryan Pandya <ryan@ryanpandya.com>
Date: Wed, 4 Dec 2024 12:44:24 -0800
Subject: [PATCH] Fix updating categories

---
 .../dashboard/categories/CategoriesView.tsx   |  6 +-
 .../categories/EditCategoryDialog.tsx         | 19 ++---
 packages/shared/types/categories.ts           | 10 ++-
 packages/trpc/routers/categories.ts           | 70 +++++--------------
 4 files changed, 42 insertions(+), 63 deletions(-)

diff --git a/apps/web/components/dashboard/categories/CategoriesView.tsx b/apps/web/components/dashboard/categories/CategoriesView.tsx
index 85454cc..7dc831d 100644
--- a/apps/web/components/dashboard/categories/CategoriesView.tsx
+++ b/apps/web/components/dashboard/categories/CategoriesView.tsx
@@ -68,7 +68,11 @@ export default function CategoriesView() {
               >
                 <Trash size={16} color="red" />
               </ActionButtonWithTooltip>
-              <EditCategoryDialog categoryId={c.id} >
+              <EditCategoryDialog category={{
+                ...c,
+                categoryId: c.id
+              }
+              } >
                 <ButtonWithTooltip
                   tooltip="Edit"
                   variant="outline"
diff --git a/apps/web/components/dashboard/categories/EditCategoryDialog.tsx b/apps/web/components/dashboard/categories/EditCategoryDialog.tsx
index 56c09d9..b0061f1 100644
--- a/apps/web/components/dashboard/categories/EditCategoryDialog.tsx
+++ b/apps/web/components/dashboard/categories/EditCategoryDialog.tsx
@@ -33,22 +33,25 @@ import { TRPCClientError } from "@trpc/client";
 import { useForm } from "react-hook-form";
 import { z } from "zod";
 
-import { zCategorySchema } from "@lifetracker/shared/types/categories";
-
-type CreateCategorySchema = z.infer<typeof zCategorySchema>;
+import { zUpdateCategoryRequestSchema, ZUpdateCategoryRequest } from "@lifetracker/shared/types/categories";
 
 export default function EditCategoryDialog({
+  category: initialCategory,
   children,
 }: {
+  category: ZUpdateCategoryRequest;
   children?: React.ReactNode;
 }) {
   const apiUtils = api.useUtils();
   const [isOpen, onOpenChange] = useState(false);
-  const form = useForm<CreateCategorySchema>({
-    resolver: zodResolver(zCategorySchema),
+
+  const form = useForm<ZUpdateCategoryRequest>({
+    resolver: zodResolver(zUpdateCategoryRequestSchema),
+    defaultValues: initialCategory,
   });
   const { mutate, isPending } = api.categories.update.useMutation({
     onSuccess: () => {
+      apiUtils.categories.list.invalidate();
       toast({
         description: "Category updated successfully",
       });
@@ -139,9 +142,9 @@ export default function EditCategoryDialog({
                   </FormItem>
                 )}
               />
-              <FormField
+              {/* <FormField
                 control={form.control}
-                name="color"
+                name="colorId"
                 render={({ field }) => (
                   <FormItem>
                     <FormLabel>Color</FormLabel>
@@ -156,7 +159,7 @@ export default function EditCategoryDialog({
                     <FormMessage />
                   </FormItem>
                 )}
-              />
+              /> */}
               <DialogFooter className="sm:justify-end">
                 <DialogClose asChild>
                   <Button type="button" variant="secondary">
diff --git a/packages/shared/types/categories.ts b/packages/shared/types/categories.ts
index ece63b6..b72fe59 100644
--- a/packages/shared/types/categories.ts
+++ b/packages/shared/types/categories.ts
@@ -32,7 +32,11 @@ export const zGetCategoryResponseSchema = z.object({
 export type ZGetCategoryResponse = z.infer<typeof zGetCategoryResponseSchema>;
 
 export const zUpdateCategoryRequestSchema = z.object({
-    labelId: z.string(),
-    code: z.number(),
+    code: z.number().nullish(),
     name: z.string().optional(),
-});
\ No newline at end of file
+    description: z.string().optional(),
+    colorId: z.string().nullish(),
+    parentId: z.string().nullish(),
+    categoryId: z.string(),
+});
+export type ZUpdateCategoryRequest = z.infer<typeof zUpdateCategoryRequestSchema>;
\ No newline at end of file
diff --git a/packages/trpc/routers/categories.ts b/packages/trpc/routers/categories.ts
index 0e95076..a55586f 100644
--- a/packages/trpc/routers/categories.ts
+++ b/packages/trpc/routers/categories.ts
@@ -17,8 +17,9 @@ import { authedProcedure, router } from "../index";
 import { zColorSchema } from "@lifetracker/shared/types/colors";
 
 
-function conditionFromInput(input: { categoryCode: string }, userId: string) {
-    return and(eq(categories.code, input.categoryCode), eq(categories.userId, userId));
+function conditionFromInput(input: { categoryCode?: string, categoryId?: string }, userId: string) {
+    const queryType = input.categoryCode ? eq(categories.code, input.categoryCode) : eq(categories.id, input.categoryId);
+    return and(queryType, eq(categories.userId, userId));
 }
 
 async function createCategory(
@@ -221,55 +222,22 @@ export const categoriesAppRouter = router({
             }),
         )
         .mutation(async ({ input, ctx }) => {
-            try {
-                const res = await ctx.db
-                    .update(bookmarkTags)
-                    .set({
-                        name: input.name,
-                    })
-                    .where(
-                        and(
-                            eq(bookmarkTags.id, input.tagId),
-                            eq(bookmarkTags.userId, ctx.user.id),
-                        ),
-                    )
-                    .returning();
-
-                if (res.length == 0) {
-                    throw new TRPCError({ code: "NOT_FOUND" });
-                }
-
-                try {
-                    const affectedBookmarks = await ctx.db.query.tagsOnBookmarks.findMany(
-                        {
-                            where: eq(tagsOnBookmarks.tagId, input.tagId),
-                            columns: {
-                                bookmarkId: true,
-                            },
-                        },
-                    );
-                    await Promise.all(
-                        affectedBookmarks
-                            .map((b) => b.bookmarkId)
-                            .map((id) => triggerSearchReindex(id)),
-                    );
-                } catch (e) {
-                    console.error("Something ELSE Went Wrong", e);
-                }
-
-                return res[0];
-            } catch (e) {
-                if (e instanceof SqliteError) {
-                    if (e.code == "SQLITE_CONSTRAINT_UNIQUE") {
-                        throw new TRPCError({
-                            code: "BAD_REQUEST",
-                            message:
-                                "Label name already exists.",
-                        });
-                    }
-                }
-                throw e;
-            }
+            console.log("Updating");
+            const res = await ctx.db
+                .update(categories)
+                .set({
+                    name: input.name,
+                    description: input.description,
+                    code: input.code,
+                })
+                .where(
+                    and(
+                        conditionFromInput({ categoryId: input.categoryId }, ctx.user.id),
+                        eq(categories.userId, ctx.user.id),
+                    ),
+                ).returning();
+            console.log(res);
+            return res[0];
         }),
     delete: authedProcedure
         .input(